netdev - Re: [PATCH] net: ipvlan: Fix ipvlan device tso disabled while NETIF_F_IP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190604.200132.328184377847137118.davem@davemloft.net>
Date:   Tue, 04 Jun 2019 20:01:32 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     linmiaohe@...wei.com
Cc:     idosch@...lanox.com, daniel@...earbox.net, petrm@...lanox.com,
        jiri@...lanox.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, mingfangsen@...wei.com,
        wangxiaogang3@...wei.com
Subject: Re: [PATCH] net: ipvlan: Fix ipvlan device tso disabled while
 NETIF_F_IP_CSUM is set

From: Miaohe Lin <linmiaohe@...wei.com>
Date: Tue, 4 Jun 2019 06:07:34 +0000

> There's some NICs, such as hinic, with NETIF_F_IP_CSUM and NETIF_F_TSO
> on but NETIF_F_HW_CSUM off. And ipvlan device features will be
> NETIF_F_TSO on with NETIF_F_IP_CSUM and NETIF_F_IP_CSUM both off as
> IPVLAN_FEATURES only care about NETIF_F_HW_CSUM. So TSO will be
> disabled in netdev_fix_features.
> For example:
> Features for enp129s0f0:
> rx-checksumming: on
> tx-checksumming: on
>         tx-checksum-ipv4: on
>         tx-checksum-ip-generic: off [fixed]
>         tx-checksum-ipv6: on
> 
> Fixes: a188222b6ed2 ("net: Rename NETIF_F_ALL_CSUM to NETIF_F_CSUM_MASK")
> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>

Applied.