netdev - Re: [PATCH 1/1] bpf: Allow bpf_map_lookup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190605223111.rgsd3tyl7jvahvgc@kafai-mbp.dhcp.thefacebook.com>
Date:   Wed, 5 Jun 2019 22:31:14 +0000
From:   Martin Lau <kafai@...com>
To:     Jonathan Lemon <jonathan.lemon@...il.com>
CC:     "bjorn.topel@...el.com" <bjorn.topel@...el.com>,
        "magnus.karlsson@...el.com" <magnus.karlsson@...el.com>,
        "toke@...hat.com" <toke@...hat.com>,
        "brouer@...hat.com" <brouer@...hat.com>,
        Kernel Team <Kernel-team@...com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "daniel@...earbox.net" <daniel@...earbox.net>,
        "ast@...nel.org" <ast@...nel.org>
Subject: Re: [PATCH 1/1] bpf: Allow bpf_map_lookup_elem() on an xskmap

On Wed, Jun 05, 2019 at 08:57:56AM -0700, Jonathan Lemon wrote:
> Currently, the AF_XDP code uses a separate map in order to
> determine if an xsk is bound to a queue.  Instead of doing this,
> have bpf_map_lookup_elem() return a xdp_sock.
> 
> Rearrange some xdp_sock members to eliminate structure holes.
> 
> Signed-off-by: Jonathan Lemon <jonathan.lemon@...il.com>
> ---
>  include/linux/bpf.h                           |  8 ++++
>  include/net/xdp_sock.h                        |  4 +-
>  include/uapi/linux/bpf.h                      |  4 ++
>  kernel/bpf/verifier.c                         | 26 +++++++++++-
>  kernel/bpf/xskmap.c                           |  7 ++++
>  net/core/filter.c                             | 40 +++++++++++++++++++
>  tools/include/uapi/linux/bpf.h                |  4 ++P
The convention is to submit this uapi's bpf.h sync to tools/ in
a separate patch to make conflicts easier to be dealt with.
It will be the 2nd patch.

>  .../bpf/verifier/prevent_map_lookup.c         | 15 -------
>  tools/testing/selftests/bpf/verifier/sock.c   | 18 +++++++++
Hence, the selftest changes will be in the 3rd patch.

Others LGTM,
Acked-by: Martin KaFai Lau <kafai@...com>