netdev - Re: [net-next 2/2] i40e: Check and set the PF driver state first in i40e_ndo_set_vf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190605.165350.2288911528761294407.davem@davemloft.net>
Date:   Wed, 05 Jun 2019 16:53:50 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jeffrey.t.kirsher@...el.com
Cc:     lihong.yang@...el.com, netdev@...r.kernel.org, nhorman@...hat.com,
        sassmann@...hat.com
Subject: Re: [net-next 2/2] i40e: Check and set the PF driver state first
 in i40e_ndo_set_vf_mac

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Wed,  5 Jun 2019 12:45:16 -0700

> From: Lihong Yang <lihong.yang@...el.com>
> 
> The PF driver state flag __I40E_VIRTCHNL_OP_PENDING needs to be
> checked and set at the beginning of i40e_ndo_set_vf_mac. Otherwise,
> if there are error conditions before it, the flag will be cleared
> unexpectedly by this function to cause potential race conditions.
> Hence move the check to the top of this function.
> 
> Signed-off-by: Lihong Yang <lihong.yang@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

Applied.