netdev - Re: [PATCH net] fib_rules: return 0 directly if an exactly same rule exists when NLM_F

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190605040801.GC18865@dhcp-12-139.nay.redhat.com>
Date:   Wed, 5 Jun 2019 12:08:02 +0800
From:   Hangbin Liu <liuhangbin@...il.com>
To:     David Ahern <dsa@...ulusnetworks.com>
Cc:     David Ahern <dsahern@...il.com>,
        David Miller <davem@...emloft.net>,
        Yaro Slav <yaro330@...il.com>,
        Thomas Haller <thaller@...hat.com>,
        Lorenzo Colitti <lorenzo@...gle.com>, astrachan@...gle.com,
        Greg KH <greg@...ah.com>,
        Linux NetDev <netdev@...r.kernel.org>,
        mateusz.bajorski@...ia.com,
        Maciej Żenczykowski <zenczykowski@...il.com>
Subject: Re: [PATCH net] fib_rules: return 0 directly if an exactly same rule
 exists when NLM_F_EXCL not supplied

On Tue, Jun 04, 2019 at 09:57:56PM -0600, David Ahern wrote:
> On 6/4/19 7:43 PM, Hangbin Liu wrote:
> > Hi David Ahern,
> > 
> > On Fri, May 31, 2019 at 06:43:42PM -0700, Maciej Żenczykowski wrote:
> >> FYI, this userspace visible change in behaviour breaks Android.
> >>
> >> We rely on being able to add a rule and either have a dup be created
> >> (in which case we'll remove it later) or have it fail with EEXIST (in
> >> which case we won't remove it later).
> >>
> >> Returning 0 makes atomically changing a rule difficult.
> >>
> >> Please revert.
> > What do you think? Should I rever this commit?
> 
> I think it is crazy to add multiple identical rules given the linear
> effect on performance. But, since it breaks Android, it has to be reverted.

OK.. Since you also agree to revert it.

Thanks
Hangbin