netdev - Re: [PATCH net-next 6/9] ptp: ptp_clock: Publish scaled_ppm_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1ec59a66-2975-0372-6de1-3fca72baf43d@mellanox.com>
Date:   Wed, 5 Jun 2019 11:46:48 +0000
From:   Shalom Toledo <shalomt@...lanox.com>
To:     Richard Cochran <richardcochran@...il.com>,
        Ido Schimmel <idosch@...sch.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        Jiri Pirko <jiri@...lanox.com>,
        Petr Machata <petrm@...lanox.com>, mlxsw <mlxsw@...lanox.com>,
        Ido Schimmel <idosch@...lanox.com>
Subject: Re: [PATCH net-next 6/9] ptp: ptp_clock: Publish scaled_ppm_to_ppb

On 04/06/2019 17:21, Richard Cochran wrote:
> On Mon, Jun 03, 2019 at 03:12:41PM +0300, Ido Schimmel wrote:
>> From: Shalom Toledo <shalomt@...lanox.com>
>>
>> Publish scaled_ppm_to_ppb to allow drivers to use it.
> 
> But why?

See my comment in patch #7

> 
>> @@ -63,7 +63,7 @@ static void enqueue_external_timestamp(struct timestamp_event_queue *queue,
>>  	spin_unlock_irqrestore(&queue->lock, flags);
>>  }
>>  
>> -static s32 scaled_ppm_to_ppb(long ppm)
>> +s32 ptp_clock_scaled_ppm_to_ppb(long ppm)
> 
> Six words is a little bit much for the name of a function.

I can make it scaled_ppm_to_ppb() as before. Is that ok? or maybe you have
something else in your mind?

> 
> Thanks,
> Richard
>