lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 05 Jun 2019 17:16:08 -0700 (PDT) From: David Miller <davem@...emloft.net> To: vivien.didelot@...il.com Cc: netdev@...r.kernel.org, mkubecek@...e.cz, linville@...hat.com, f.fainelli@...il.com Subject: Re: [PATCH net v2] ethtool: fix potential userspace buffer overflow From: Vivien Didelot <vivien.didelot@...il.com> Date: Mon, 3 Jun 2019 16:57:13 -0400 > ethtool_get_regs() allocates a buffer of size ops->get_regs_len(), > and pass it to the kernel driver via ops->get_regs() for filling. > > There is no restriction about what the kernel drivers can or cannot do > with the open ethtool_regs structure. They usually set regs->version > and ignore regs->len or set it to the same size as ops->get_regs_len(). > > But if userspace allocates a smaller buffer for the registers dump, > we would cause a userspace buffer overflow in the final copy_to_user() > call, which uses the regs.len value potentially reset by the driver. > > To fix this, make this case obvious and store regs.len before calling > ops->get_regs(), to only copy as much data as requested by userspace, > up to the value returned by ops->get_regs_len(). > > While at it, remove the redundant check for non-null regbuf. > > Signed-off-by: Vivien Didelot <vivien.didelot@...il.com> Applied and queued up for -stable, thanks.
Powered by blists - more mailing lists