netdev - Re: [PATCH net] net: aquantia: fix wol configuration not applied sometimes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 05 Jun 2019 17:42:14 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     Igor.Russkikh@...antia.com
Cc:     netdev@...r.kernel.org, Nikita.Danilov@...antia.com
Subject: Re: [PATCH net] net: aquantia: fix wol configuration not applied
 sometimes

From: Igor Russkikh <Igor.Russkikh@...antia.com>
Date: Tue, 4 Jun 2019 13:23:49 +0000

> From: Nikita Danilov <nikita.danilov@...antia.com>
> 
> WoL magic packet configuration sometimes does not work due to
> couple of leakages found.
> 
> Mainly there was a regression introduced during readx_poll refactoring.
> 
> Next, fw request waiting time was too small. Sometimes that
> caused sleep proxy config function to return with an error
> and to skip WoL configuration.
> At last, WoL data were passed to FW from not clean buffer.
> That could cause FW to accept garbage as a random configuration data.
> 
> Signed-off-by: Nikita Danilov <nikita.danilov@...antia.com>
> Signed-off-by: Igor Russkikh <igor.russkikh@...antia.com>
> Fixes: 6a7f2277313b ("net: aquantia: replace AQ_HW_WAIT_FOR with readx_poll_timeout_atomic")

Applied and queued up for -stable.