netdev - Re: [PATCH iproute2-next] devlink: Increase bus,device buffer size to 64 bytes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 6 Jun 2019 08:18:59 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Parav Pandit <parav@...lanox.com>
Cc:     dsahern@...il.com, netdev@...r.kernel.org, jiri@...lanox.com
Subject: Re: [PATCH iproute2-next] devlink: Increase bus,device buffer size
 to 64 bytes

On Thu,  6 Jun 2019 06:49:19 -0500
Parav Pandit <parav@...lanox.com> wrote:

> Device name on mdev bus is 36 characters long which follow standard uuid
> RFC 4122.
> This is probably the longest name that a kernel will return for a
> device.
> 
> Hence increase the buffer size to 64 bytes.
> 
> Acked-by: Jiri Pirko <jiri@...lanox.com>
> Signed-off-by: Parav Pandit <parav@...lanox.com>
> 
> ---
>  devlink/devlink.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/devlink/devlink.c b/devlink/devlink.c
> index 436935f8..559f624e 100644
> --- a/devlink/devlink.c
> +++ b/devlink/devlink.c
> @@ -1523,7 +1523,7 @@ static void __pr_out_handle_start(struct dl *dl, struct nlattr **tb,
>  {
>  	const char *bus_name = mnl_attr_get_str(tb[DEVLINK_ATTR_BUS_NAME]);
>  	const char *dev_name = mnl_attr_get_str(tb[DEVLINK_ATTR_DEV_NAME]);
> -	char buf[32];
> +	char buf[64];
>  
>  	sprintf(buf, "%s/%s", bus_name, dev_name);
>  
> @@ -1616,7 +1616,7 @@ static void __pr_out_port_handle_start(struct dl *dl, const char *bus_name,
>  				       uint32_t port_index, bool try_nice,
>  				       bool array)
>  {
> -	static char buf[32];
> +	static char buf[64];
>  	char *ifname = NULL;
>  
>  	if (dl->no_nice_names || !try_nice ||

I will take this now no need to wait for next