netdev - Re: [PATCH net] Revert "fib_rules: return 0 directly if an exactly same rule exists when NLM_F

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 05 Jun 2019 18:41:12 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     natechancellor@...il.com
Cc:     liuhangbin@...il.com, netdev@...r.kernel.org,
        gregkh@...uxfoundation.org, zenczykowski@...il.com,
        lorenzo@...gle.com, dsa@...ulusnetworks.com, thaller@...hat.com,
        yaro330@...il.com
Subject: Re: [PATCH net] Revert "fib_rules: return 0 directly if an exactly
 same rule exists when NLM_F_EXCL not supplied"

From: Nathan Chancellor <natechancellor@...il.com>
Date: Wed, 5 Jun 2019 18:23:51 -0700

> On Wed, Jun 05, 2019 at 05:55:26PM -0700, David Miller wrote:
>> From: Hangbin Liu <liuhangbin@...il.com>
>> Date: Wed,  5 Jun 2019 12:27:14 +0800
>> 
>> > This reverts commit e9919a24d3022f72bcadc407e73a6ef17093a849.
>> > 
>> > Nathan reported the new behaviour breaks Android, as Android just add
>> > new rules and delete old ones.
>> > 
>> > If we return 0 without adding dup rules, Android will remove the new
>> > added rules and causing system to soft-reboot.
>> > 
>> > Reported-by: Nathan Chancellor <natechancellor@...il.com>
>> > Fixes: e9919a24d302 ("fib_rules: return 0 directly if an exactly same rule exists when NLM_F_EXCL not supplied")
>> > Signed-off-by: Hangbin Liu <liuhangbin@...il.com>
>> 
>> Applied.
> 
> Please ensure this gets queued up for stable, as that is where I noticed
> the issue.

It is queued up, thanks for asking.

I'll try to get this propagated as soon as possible.

Thanks again.