netdev - Re: [PATCH net-next] net: fec: Do not use netdev messages too early

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 06 Jun 2019 11:16:02 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     festevam@...il.com
Cc:     fugang.duan@....com, netdev@...r.kernel.org,
        otavio@...ystems.com.br
Subject: Re: [PATCH net-next] net: fec: Do not use netdev messages too early

From: Fabio Estevam <festevam@...il.com>
Date: Thu,  6 Jun 2019 09:40:33 -0300

> When a valid MAC address is not found the current messages
> are shown:
> 
> fec 2188000.ethernet (unnamed net_device) (uninitialized): Invalid MAC address: 00:00:00:00:00:00
> fec 2188000.ethernet (unnamed net_device) (uninitialized): Using random MAC address: aa:9f:25:eb:7e:aa
> 
> Since the network device has not been registered at this point, it is better
> to use dev_err()/dev_info() instead, which will provide cleaner log
> messages like these:
> 
> fec 2188000.ethernet: Invalid MAC address: 00:00:00:00:00:00
> fec 2188000.ethernet: Using random MAC address: aa:9f:25:eb:7e:aa
> 
> Tested on a imx6dl-pico-pi board.
> 
> Signed-off-by: Fabio Estevam <festevam@...il.com>

Applied, thanks.