netdev - Re: [PATCH] net: phy: marvell10g: allow PHY to probe without firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 05 Jun 2019 18:48:27 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     rmk+kernel@...linux.org.uk
Cc:     andrew@...n.ch, f.fainelli@...il.com, hkallweit1@...il.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH] net: phy: marvell10g: allow PHY to probe without
 firmware

From: Russell King <rmk+kernel@...linux.org.uk>
Date: Wed, 05 Jun 2019 11:43:16 +0100

> +	    (state == PHY_UP || state == PHY_RESUMING)) {

drivers/net/phy/marvell10g.c: In function ‘mv3310_link_change_notify’:
drivers/net/phy/marvell10g.c:268:35: error: ‘PHY_RESUMING’ undeclared (first use in this function); did you mean ‘RPM_RESUMING’?
      (state == PHY_UP || state == PHY_RESUMING)) {
                                   ^~~~~~~~~~~~
                                   RPM_RESUMING
drivers/net/phy/marvell10g.c:268:35: note: each undeclared identifier is reported only once for each function it appears in
At top level:
drivers/net/phy/marvell10g.c:262:13: warning: ‘mv3310_link_change_notify’ defined but not used [-Wunused-function]
 static void mv3310_link_change_notify(struct phy_device *phydev)
             ^~~~~~~~~~~~~~~~~~~~~~~~~