netdev - Re: [PATCH iproute2 v2] tc: simple: don't hardcode the control action

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 6 Jun 2019 14:45:24 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Davide Caratti <dcaratti@...hat.com>
Cc:     Andrea Claudi <aclaudi@...hat.com>,
        Marcelo Ricardo Leitner <marcelo.leitner@...il.com>,
        netdev@...r.kernel.org
Subject: Re: [PATCH iproute2 v2] tc: simple: don't hardcode the control
 action

On Wed,  5 Jun 2019 00:30:16 +0200
Davide Caratti <dcaratti@...hat.com> wrote:

> the following TDC test case:
> 
>  b776 - Replace simple action with invalid goto chain control
> 
> checks if the kernel correctly validates the 'goto chain' control action,
> when it is specified in 'act_simple' rules. The test systematically fails
> because the control action is hardcoded in parse_simple(), i.e. it is not
> parsed by command line arguments, so its value is constantly TC_ACT_PIPE.
> Because of that, the following command:
> 
>  # tc action add action simple sdata "test" drop index 7
> 
> installs an 'act_simple' rule that never drops packets, and whose 'index'
> is the first IDR available, plus an 'act_gact' rule with 'index' equal to
> 7, that drops packets.
> 
> Use parse_action_control_dflt(), like we did on many other TC actions, to
> make the control action configurable also with 'act_simple'. The expected
> results of test b776 are summarized below:
> 
>  iproute2
>    v       kernel->| 5.1-rc2 (and previous)  | 5.1-rc3 (and subsequent)
>  ------------------+-------------------------+-------------------------
>  5.1.0             | FAIL (bad IDR)          | FAIL (bad IDR)
>  5.1.0(patched)    | FAIL (no rule/bad sdata)| PASS
> 
> Changes since v1:
>  - reword commit message, thanks Stephen Hemminger
> 
> Fixes: 087f46ee4ebd ("tc: introduce simple action")
> CC: Andrea Claudi <aclaudi@...hat.com>
> CC: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
> Signed-off-by: Davide Caratti <dcaratti@...hat.com>

Applied, thanks