netdev - Re: [PATCH bpf v2 0/4] Fix unconnected bpf cgroup hooks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 6 Jun 2019 23:48:25 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Andrey Ignatov <rdna@...com>
Cc:     "alexei.starovoitov@...il.com" <alexei.starovoitov@...il.com>,
        Martin Lau <kafai@...com>, "m@...bda.lt" <m@...bda.lt>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH bpf v2 0/4] Fix unconnected bpf cgroup hooks

On 06/06/2019 10:51 PM, Andrey Ignatov wrote:
> Andrey Ignatov <rdna@...com> [Thu, 2019-06-06 13:45 -0700]:
>> Daniel Borkmann <daniel@...earbox.net> [Thu, 2019-06-06 07:36 -0700]:
>>> Please refer to the patch 1/4 as the main patch with the details
>>> on the current sendmsg hook API limitations and proposal to fix
>>> it in order to work with basic applications like DNS. Remaining
>>> patches are the usual uapi and tooling updates as well as test
>>> cases. Thanks a lot!
>>>
>>> v1 -> v2:
>>>   - Split off uapi header sync and bpftool bits (Martin, Alexei)
>>>   - Added missing bpftool doc and bash completion as well
>>>
>>> Daniel Borkmann (4):
>>>   bpf: fix unconnected udp hooks
>>>   bpf: sync tooling uapi header
>>>   bpf, bpftool: enable recvmsg attach types
>>>   bpf: add further msg_name rewrite tests to test_sock_addr
>>>
>>>  include/linux/bpf-cgroup.h                    |   8 +
>>>  include/uapi/linux/bpf.h                      |   2 +
>>>  kernel/bpf/syscall.c                          |   8 +
>>>  kernel/bpf/verifier.c                         |  12 +-
>>>  net/core/filter.c                             |   2 +
>>>  net/ipv4/udp.c                                |   4 +
>>>  net/ipv6/udp.c                                |   4 +
>>>  .../bpftool/Documentation/bpftool-cgroup.rst  |   6 +-
>>>  .../bpftool/Documentation/bpftool-prog.rst    |   2 +-
>>>  tools/bpf/bpftool/bash-completion/bpftool     |   5 +-
>>>  tools/bpf/bpftool/cgroup.c                    |   5 +-
>>>  tools/bpf/bpftool/prog.c                      |   3 +-
>>>  tools/include/uapi/linux/bpf.h                |   2 +
>>>  tools/testing/selftests/bpf/test_sock_addr.c  | 213 ++++++++++++++++--
>>>  14 files changed, 250 insertions(+), 26 deletions(-)
>>
>> tools/lib/bpf/libbpf.c should also be updated: section_names and
> 
> And tools/testing/selftests/bpf/test_section_names.c as well.
> 
>> bpf_prog_type__needs_kver. Please either follow-up separately or send

Sigh, yes, makes sense, I'll fold these in for a final v3. Thanks for
spotting!

>> v3. Other than this LGMT.
>>
>> Acked-by: Andrey Ignatov <rdna@...com>
>>
>> -- 
>> Andrey Ignatov
>