netdev - RE: [PATCH net-next 2/3] dpaa2-eth: Support multiple traffic classes on Tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 6 Jun 2019 06:25:45 +0000
From:   Ioana Ciocoi Radulescu <ruxandra.radulescu@....com>
To:     David Miller <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Ioana Ciornei <ioana.ciornei@....com>
Subject: RE: [PATCH net-next 2/3] dpaa2-eth: Support multiple traffic classes
 on Tx

> -----Original Message-----
> From: David Miller <davem@...emloft.net>
> Sent: Thursday, June 6, 2019 4:46 AM
> To: Ioana Ciocoi Radulescu <ruxandra.radulescu@....com>
> Cc: netdev@...r.kernel.org; Ioana Ciornei <ioana.ciornei@....com>
> Subject: Re: [PATCH net-next 2/3] dpaa2-eth: Support multiple traffic classes
> on Tx
> 
> From: Ioana Radulescu <ruxandra.radulescu@....com>
> Date: Wed,  5 Jun 2019 12:57:25 +0300
> 
> > +	queue_mapping %= dpaa2_eth_queue_count(priv);
> 
> You are now performing a very expensive modulus operation every single TX
> packet, regardless of whether TC is in use or not.
> 
> The whole reason we store the queue mapping pre-cooked in the SKB is so
> that you don't have to do this.

Good point, thanks. Will refactor and send a v2.

Ioana