netdev - Re: [pull request][for-next 0/9] Generic DIM lib for netdev and RDMA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9faeadac971aaf481b1066b1dde0fc9e77e893a5.camel@mellanox.com>
Date:   Fri, 7 Jun 2019 18:14:11 +0000
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     Jason Gunthorpe <jgg@...lanox.com>,
        Max Gurtovoy <maxg@...lanox.com>
CC:     "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "andy@...yhouse.net" <andy@...yhouse.net>,
        Tal Gilboa <talgi@...lanox.com>,
        "michael.chan@...adcom.com" <michael.chan@...adcom.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "leon@...nel.org" <leon@...nel.org>,
        "dledford@...hat.com" <dledford@...hat.com>
Subject: Re: [pull request][for-next 0/9] Generic DIM lib for netdev and RDMA

On Thu, 2019-06-06 at 13:07 +0000, Jason Gunthorpe wrote:
> On Thu, Jun 06, 2019 at 10:19:41AM +0300, Max Gurtovoy wrote:
> > > > Solution:
> > > > - Common logic is declared in include/linux/dim.h and
> > > > implemented in
> > > >    lib/dim/dim.c
> > > > - Net DIM (existing) logic is declared in
> > > > include/linux/net_dim.h and
> > > >    implemented in lib/dim/net_dim.c, which uses the common
> > > > logic from dim.h
> > > > - Any new DIM logic will be declared in
> > > > "/include/linux/new_dim.h" and
> > > >     implemented in "lib/dim/new_dim.c".
> > > > - This new implementation will expose modified versions of
> > > > profiles,
> > > >    dim_step() and dim_decision().
> > > > 
> > > > Pros for this solution are:
> > > > - Zero impact on existing net_dim implementation and usage
> > > > - Relatively more code reuse (compared to two separate
> > > > solutions)
> > > > - Increased extensibility
> > > > 
> > > > Tal Gilboa (6):
> > > >        linux/dim: Move logic to dim.h
> > > >        linux/dim: Remove "net" prefix from internal DIM members
> > > >        linux/dim: Rename externally exposed macros
> > > >        linux/dim: Rename net_dim_sample() to
> > > > net_dim_update_sample()
> > > >        linux/dim: Rename externally used net_dim members
> > > >        linux/dim: Move implementation to .c files
> > > > 
> > > > Yamin Friedman (3):
> > > >        linux/dim: Add completions count to dim_sample
> > > >        linux/dim: Implement rdma_dim
> > > >        RDMA/core: Provide RDMA DIM support for ULPs
> > > Saeed,
> > > 
> > > No, for the RDMA patches.
> > > We need to see usage of those APIs before merging.
> > 
> > I've asked Yamin to prepare patches for NVMeoF initiator and target
> > for
> > review, so I guess he has it on his plate (this is how he tested
> > it..).
> > 
> > It might cause conflict with NVMe/blk branch maintained by Sagi,
> > Christoph
> > and Jens.
> 
> It looks like nvme could pull this series + the RDMA patches into the
> nvme tree via PR? I'm not familiar with how that tree works.
> 
> But we need to get the patches posted right away..
> 

What do you suggest here ?
I think the netdev community also deserve to see the rdma patches, at
least with an external link, I can drop the last patch (or two ) ? but
i need an external rdma link for people who are going to review this
series.

> Jason