netdev - Re: [PATCH v2 net-next 07/20] ipv6: Handle all fib6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3a7ea5b0-07cb-791a-171d-93047e365473@gmail.com>
Date:   Fri, 7 Jun 2019 16:39:44 -0600
From:   David Ahern <dsahern@...il.com>
To:     Wei Wang <weiwan@...gle.com>, David Ahern <dsahern@...nel.org>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        idosch@...lanox.com, Martin KaFai Lau <kafai@...com>,
        Stefano Brivio <sbrivio@...hat.com>
Subject: Re: [PATCH v2 net-next 07/20] ipv6: Handle all fib6_nh in a nexthop
 in exception handling

On 6/7/19 4:05 PM, Wei Wang wrote:
>> @@ -1835,6 +1848,24 @@ static int fib6_nh_remove_exception(const struct fib6_nh *nh, int plen,
>>         return err;
>>  }
>>
>> +struct fib6_nh_excptn_arg {
>> +       struct rt6_info *rt;
>> +       int             plen;
>> +       bool            found;
>> +};
>> +
>> +static int rt6_nh_remove_exception_rt(struct fib6_nh *nh, void *_arg)
>> +{
>> +       struct fib6_nh_excptn_arg *arg = _arg;
>> +       int err;
>> +
>> +       err = fib6_nh_remove_exception(nh, arg->plen, arg->rt);
>> +       if (err == 0)
>> +               arg->found = true;
>> +
>> +       return 0;
>> +}
>> +
> Hi David,
> Why not return 1 here to break the loop when
> fib6_nh_remove_exception() successfully removed the rt?
> 

will change. update will drop the found arg and let rc == 1 indicate an
entry was found.