netdev - Re: [PATCH 1/8] drivers: net: dsa: realtek: fix warning same module names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdZdQPuLKtpsgA4zUeFhubeTwajDUAzvsQ9RY0Q3WFKxcQ@mail.gmail.com>
Date:   Sat, 8 Jun 2019 01:21:54 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Anders Roxell <anders.roxell@...aro.org>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Heiner Kallweit <hkallweit1@...il.com>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH 1/8] drivers: net: dsa: realtek: fix warning same module names

On Thu, Jun 6, 2019 at 2:50 PM Andrew Lunn <andrew@...n.ch> wrote:
> On Thu, Jun 06, 2019 at 11:47:07AM +0200, Anders Roxell wrote:
> > When building with CONFIG_NET_DSA_REALTEK_SMI and CONFIG_REALTEK_PHY
> > enabled as loadable modules, we see the following warning:
> >
> > warning: same module names found:
> >   drivers/net/phy/realtek.ko
> >   drivers/net/dsa/realtek.ko
> >
> > Rework so the names matches the config fragment.
> >
> > Signed-off-by: Anders Roxell <anders.roxell@...aro.org>
>
> [Removes most of the Cc:]
>
> Hi Anders
>
> Please base this patch on net-next and submit it to David
> Miller/netdev.
>
> It would also be nice to state the new name of the module in the
> commit message.
>
> Linus, would you prefer this module is called rtl8366?

Yes that should be unique enough!

Anders: thanks for looking into this. I just always compiled
all modules as y.

Yours,
Linus Walleij