netdev - Re: [PATCH v5 bpf-next 0/4] Better handling of xskmap entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJ+HfNgL56oxWUM7qGxyQOH0AyKjYJWu6z=77xcMw7K+iqZ0WQ@mail.gmail.com>
Date:   Sun, 9 Jun 2019 08:52:25 +0200
From:   Björn Töpel <bjorn.topel@...il.com>
To:     Jonathan Lemon <jonathan.lemon@...il.com>
Cc:     Björn Töpel <bjorn.topel@...el.com>,
        "Karlsson, Magnus" <magnus.karlsson@...el.com>,
        Toke Høiland-Jørgensen <toke@...hat.com>,
        Jesper Dangaard Brouer <brouer@...hat.com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Alexei Starovoitov <ast@...nel.org>,
        Kernel Team <kernel-team@...com>,
        Netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH v5 bpf-next 0/4] Better handling of xskmap entries

On Fri, 7 Jun 2019 at 00:30, Jonathan Lemon <jonathan.lemon@...il.com> wrote:
>
> Currently, the AF_XDP code uses a separate map in order to
> determine if an xsk is bound to a queue.  Have the xskmap
> lookup return a XDP_SOCK pointer on the kernel side, which
> the verifier uses to extract relevant values.
>

Very nice! Thanks for doing this, Jonathan.

Again, for the series:

Acked-by: Björn Töpel <bjorn.topel@...el.com>

> Patches:
>  1 - adds XSK_SOCK type
>  2 - sync bpf.h with tools
>  3 - add tools selftest
>  4 - update lib/bpf, removing qidconf
>
> v4->v5:
>  - xskmap lookup now returns XDP_SOCK type instead of pointer to element.
>  - no changes lib/bpf/xsk.c
>
> v3->v4:
>  - Clarify error handling path.
>
> v2->v3:
>  - Use correct map type.
>
> Jonathan Lemon (4):
>   bpf: Allow bpf_map_lookup_elem() on an xskmap
>   bpf/tools: sync bpf.h
>   tools/bpf: Add bpf_map_lookup_elem selftest for xskmap
>   libbpf: remove qidconf and better support external bpf programs.
>
>  include/linux/bpf.h                           |   8 ++
>  include/net/xdp_sock.h                        |   4 +-
>  include/uapi/linux/bpf.h                      |   4 +
>  kernel/bpf/verifier.c                         |  26 ++++-
>  kernel/bpf/xskmap.c                           |   7 ++
>  net/core/filter.c                             |  40 +++++++
>  tools/include/uapi/linux/bpf.h                |   4 +
>  tools/lib/bpf/xsk.c                           | 103 +++++-------------
>  .../bpf/verifier/prevent_map_lookup.c         |  15 ---
>  tools/testing/selftests/bpf/verifier/sock.c   |  18 +++
>  10 files changed, 135 insertions(+), 94 deletions(-)
>
> --
> 2.17.1
>