netdev - Re: [PATCH net] mpls: fix warning with multi-label encap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190609.132711.1638417451646515443.davem@davemloft.net>
Date:   Sun, 09 Jun 2019 13:27:11 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     gwilkie@...tta.att-mail.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net] mpls: fix warning with multi-label encap

From: George Wilkie <gwilkie@...tta.att-mail.com>
Date: Fri,  7 Jun 2019 11:49:41 +0100

> If you configure a route with multiple labels, e.g.
>   ip route add 10.10.3.0/24 encap mpls 16/100 via 10.10.2.2 dev ens4
> A warning is logged:
>   kernel: [  130.561819] netlink: 'ip': attribute type 1 has an invalid
>   length.
> 
> This happens because mpls_iptunnel_policy has set the type of
> MPLS_IPTUNNEL_DST to fixed size NLA_U32.
> Change it to a minimum size.
> nla_get_labels() does the remaining validation.
> 
> Signed-off-by: George Wilkie <gwilkie@...tta.att-mail.com>

Applied and queued up for -stable, thanks.