netdev - Re: [PATCH v2 next] nexthop: off by one in nexthop_mpath

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190609.133807.1807112771773489916.davem@davemloft.net>
Date:   Sun, 09 Jun 2019 13:38:07 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     dan.carpenter@...cle.com
Cc:     dsahern@...nel.org, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH v2 next] nexthop: off by one in nexthop_mpath_select()

From: Dan Carpenter <dan.carpenter@...cle.com>
Date: Fri, 7 Jun 2019 18:31:07 +0300

> The nhg->nh_entries[] array is allocated in nexthop_grp_alloc() and it
> has nhg->num_nh elements so this check should be >= instead of >.
> 
> Fixes: 430a049190de ("nexthop: Add support for nexthop groups")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> Reviewed-by: David Ahern <dsahern@...il.com>
> ---
> v2: Use the correct Fixes tag

Applied, thanks Dan.