netdev - Re: [PATCH] net: phy: marvell10g: allow PHY to probe without firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bdb416f7-3f4c-dbcf-3efe-338ab697b4fe@gmail.com>
Date:   Mon, 10 Jun 2019 15:40:10 +0200
From:   Heiner Kallweit <hkallweit1@...il.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Russell King - ARM Linux admin <linux@...linux.org.uk>,
        David Miller <davem@...emloft.net>, f.fainelli@...il.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH] net: phy: marvell10g: allow PHY to probe without firmware

On 06.06.2019 20:36, Andrew Lunn wrote:
> 65;5402;1c> I don't like too much state changes outside control of the state machine,
>> like in phy_start / phy_stop / phy_error. I think it would be better
>> if a state change request is sent to the state machine, and the state
>> machine decides whether the requested transition is allowed.
> 
> Hi Heiner
> 
> I initially though that phy_error() would be a good way to do what
> Russell wants. But the locks get in the way. Maybe add an unlocked
> version which PHY drivers can use to indicate something fatal has
> happened?
> 
phy_error() switches to PHY_HALTED, therefore phy_start() would start
another attempt to bring up the PHY. Maybe some new state like
PHY_PERMANENT_FAILURE could be helpful.  Or do we need a temporary
failure state?

After a recent patch from Russell the probe callback returns -ENODEV
if no firmware is loaded. With the patch starting this discussion
this would have changed to not failing in probe but preventing the
PHY from coming up. The commit message missed an explanation what we
gain with this behavior change.

> 	Andrew
> 
Heiner