netdev - [PATCH bpf-next v3 0/5] net: xdp: refactor XDP program queries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190610160234.4070-1-bjorn.topel@gmail.com>
Date:   Mon, 10 Jun 2019 18:02:29 +0200
From:   Björn Töpel <bjorn.topel@...il.com>
To:     ast@...nel.org, daniel@...earbox.net, netdev@...r.kernel.org
Cc:     Björn Töpel <bjorn.topel@...il.com>,
        magnus.karlsson@...el.com, bjorn.topel@...el.com, toke@...hat.com,
        brouer@...hat.com, bpf@...r.kernel.org,
        jakub.kicinski@...ronome.com, saeedm@...lanox.com
Subject: [PATCH bpf-next v3 0/5] net: xdp: refactor XDP program queries

Here's yet another attempt tomove the XDP_QUERY_PROG{,_HW} code out
from the drivers to generic netdev code.

I took a bit different approach with the v3. In this revision I
introduced to a new netdev_xdp structure that tracks the XDP programs,
and instead of sharing the xdp_prog member between DRV and SKB (again,
they mutual exclusive). With this, there's no need for a special
"what-mode-am-I-in" flag for SKB/DRV.

Jakub, what's your thoughts on the special handling of XDP offloading?
Maybe it's just overkill? Just allocate space for the offloaded
program regardless support or not? Also, please review the
dev_xdp_support_offload() addition into the nfp code.

The last two patches move the attach flag checks to generic code, and
removes the flags member from netdev_bpf.

Please refer to the individual commit messages for more details.

The series passes test_offload.py from selftests. Thanks to Jakub for
pointing this out.

Thanks,
Björn

Björn Töpel (5):
  net: xdp: refactor XDP_QUERY_PROG{,_HW} to netdev
  nfp, netdevsim: use dev_xdp_support_offload() function
  net: xdp: remove XDP_QUERY_PROG{,_HW}
  net: xdp: refactor XDP flags checking
  net: xdp: remove xdp_attachment_flags_ok() and flags member

 drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c |   4 -
 .../net/ethernet/cavium/thunder/nicvf_main.c  |   3 -
 .../net/ethernet/freescale/dpaa2/dpaa2-eth.c  |   3 -
 drivers/net/ethernet/intel/i40e/i40e_main.c   |   3 -
 drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |   4 -
 .../net/ethernet/intel/ixgbevf/ixgbevf_main.c |   4 -
 .../net/ethernet/mellanox/mlx4/en_netdev.c    |  24 ---
 .../net/ethernet/mellanox/mlx5/core/en_main.c |  18 --
 .../ethernet/netronome/nfp/nfp_net_common.c   |  10 -
 .../net/ethernet/netronome/nfp/nfp_net_main.c |   7 +
 .../net/ethernet/qlogic/qede/qede_filter.c    |   3 -
 drivers/net/netdevsim/bpf.c                   |   7 -
 drivers/net/netdevsim/netdev.c                |   4 +
 drivers/net/netdevsim/netdevsim.h             |   2 +-
 drivers/net/tun.c                             |  15 --
 drivers/net/veth.c                            |  15 --
 drivers/net/virtio_net.c                      |  17 --
 include/linux/netdevice.h                     |  30 +--
 include/net/xdp.h                             |   5 -
 net/core/dev.c                                | 172 ++++++++++++------
 net/core/rtnetlink.c                          |  31 +---
 net/core/xdp.c                                |  22 ---
 22 files changed, 147 insertions(+), 256 deletions(-)

-- 
2.20.1