netdev - Re: [PATCH net] nfp: ensure skb network header is set for packet redirect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190609.200831.1379938472199180553.davem@davemloft.net>
Date:   Sun, 09 Jun 2019 20:08:31 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jakub.kicinski@...ronome.com
Cc:     netdev@...r.kernel.org, oss-drivers@...ronome.com,
        john.hurley@...ronome.com
Subject: Re: [PATCH net] nfp: ensure skb network header is set for packet
 redirect

From: Jakub Kicinski <jakub.kicinski@...ronome.com>
Date: Sat,  8 Jun 2019 17:48:03 -0700

> From: John Hurley <john.hurley@...ronome.com>
> 
> Packets received at the NFP driver may be redirected to egress of another
> netdev (e.g. in the case of OvS internal ports). On the egress path, some
> processes, like TC egress hooks, may expect the network header offset
> field in the skb to be correctly set. If this is not the case there is
> potential for abnormal behaviour and even the triggering of BUG() calls.
> 
> Set the skb network header field before the mac header pull when doing a
> packet redirect.
> 
> Fixes: 27f54b582567 ("nfp: allow fallback packets from non-reprs")
> Signed-off-by: John Hurley <john.hurley@...ronome.com>
> Reviewed-by: Jakub Kicinski <jakub.kicinski@...ronome.com>

Applied.