netdev - Re: [PATCH iproute2] ip6tunnel: fix 'ip -6 {show|change} dev <name>' cmds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190610104821.0a7c6b8a@hermes.lan>
Date:   Mon, 10 Jun 2019 10:48:21 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Mahesh Bandewar <maheshb@...gle.com>
Cc:     Mahesh Bandewar <mahesh@...dewar.net>,
        Netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH iproute2] ip6tunnel: fix 'ip -6 {show|change} dev
 <name>' cmds

On Thu,  6 Jun 2019 16:44:26 -0700
Mahesh Bandewar <maheshb@...gle.com> wrote:

> Inclusion of 'dev' is allowed by the syntax but not handled
> correctly by the command. It produces no output for show
> command and falsely successful for change command but does
> not make any changes.
> 
> can be verified with the following steps
>   # ip -6 tunnel add ip6tnl1 mode ip6gre local fd::1 remote fd::2 tos inherit ttl 127 encaplimit none
>   # ip -6 tunnel show ip6tnl1
>   <correct output>
>   # ip -6 tunnel show dev ip6tnl1
>   <no output but correct output after this change>
>   # ip -6 tunnel change dev ip6tnl1 local 2001:1234::1 remote 2001:1234::2 encaplimit none ttl 127 tos inherit allow-localremote
>   # echo $?
>   0
>   # ip -6 tunnel show ip6tnl1
>   <no changes applied, but changes are correctly applied after this change>
> 
> Signed-off-by: Mahesh Bandewar <maheshb@...gle.com>

Applied, thanks.