netdev - Re: [PATCH net-next] ipv6: tcp: send consistent autoflowlabel in TIME

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190609.201031.2069013389367638475.davem@davemloft.net>
Date:   Sun, 09 Jun 2019 20:10:31 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net-next] ipv6: tcp: send consistent autoflowlabel in
 TIME_WAIT state

From: Eric Dumazet <edumazet@...gle.com>
Date: Sat,  8 Jun 2019 17:58:51 -0700

> In case autoflowlabel is in action, skb_get_hash_flowi6()
> derives a non zero skb->hash to the flowlabel.
> 
> If skb->hash is zero, a flow dissection is performed.
> 
> Since all TCP skbs sent from ESTABLISH state inherit their
> skb->hash from sk->sk_txhash, we better keep a copy
> of sk->sk_txhash into the TIME_WAIT socket.
> 
> After this patch, ACK or RST packets sent on behalf of
> a TIME_WAIT socket have the flowlabel that was previously
> used by the flow.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied, thanks.