netdev - Re: [PATCH net] net: handle 802.1P vlan 0 packets properly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190610.142810.138225058759413106.davem@davemloft.net>
Date:   Mon, 10 Jun 2019 14:28:10 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     gvaradar@...co.com
Cc:     benve@...co.com, netdev@...r.kernel.org, govind.varadar@...il.com
Subject: Re: [PATCH net] net: handle 802.1P vlan 0 packets properly

From: Govindarajulu Varadarajan <gvaradar@...co.com>
Date: Mon, 10 Jun 2019 07:27:02 -0700

> When stack receives pkt: [802.1P vlan 0][802.1AD vlan 100][IPv4],
> vlan_do_receive() returns false if it does not find vlan_dev. Later
> __netif_receive_skb_core() fails to find packet type handler for
> skb->protocol 801.1AD and drops the packet.
> 
> 801.1P header with vlan id 0 should be handled as untagged packets.
> This patch fixes it by checking if vlan_id is 0 and processes next vlan
> header.
> 
> Signed-off-by: Govindarajulu Varadarajan <gvaradar@...co.com>

Under Linux we absolutely do not decapsulate the VLAN protocol unless
a VLAN device is configured on that interface.