netdev - Re: [PATCH net-next] tcp: take care of SYN_RECV sockets in tcp_v4_send_ack() and tcp_v6_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89i+4Xr-0m7X_NoEnO-uBD3XR7PV8UsMVKk=xunoLH=Cf8A@mail.gmail.com>
Date:   Mon, 10 Jun 2019 15:09:20 -0700
From:   Eric Dumazet <edumazet@...gle.com>
To:     David Miller <davem@...emloft.net>
Cc:     netdev <netdev@...r.kernel.org>,
        Eric Dumazet <eric.dumazet@...il.com>, jmaxwell37@...il.com
Subject: Re: [PATCH net-next] tcp: take care of SYN_RECV sockets in
 tcp_v4_send_ack() and tcp_v6_send_response()

On Mon, Jun 10, 2019 at 3:04 PM David Miller <davem@...emloft.net> wrote:
>
> From: Eric Dumazet <edumazet@...gle.com>
> Date: Mon, 10 Jun 2019 14:45:43 -0700
>
> > Using sk_to_full_sk() should get back to the listener socket.
>
> net/ipv6/tcp_ipv6.c: In function ‘tcp_v6_send_response’:
> net/ipv6/tcp_ipv6.c:887:22: warning: passing argument 1 of ‘sk_to_full_sk’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]

I was about to ask you to drop this patch.

Apparently the only case we can have SYN_RECV sockets here are for
fastopen, and in this case sk->sk_mark defined.

This only leaves the chance to get better sock_net_uid() reach,
and my upcoming patch adding per-tcp-socket arbitrary tx delay.