netdev - Re: [PATCH net-next 1/1] ipv6: tcp: fix potential NULL deref in tcp_v6_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 09 Jun 2019 19:42:39 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com,
        syzkaller@...glegroups.com
Subject: Re: [PATCH net-next 1/1] ipv6: tcp: fix potential NULL deref in
 tcp_v6_send_reset()

From: Eric Dumazet <edumazet@...gle.com>
Date: Fri,  7 Jun 2019 12:23:48 -0700

> syzbot found a crash in tcp_v6_send_reset() caused by my latest
> change.
> 
> Problem is that if an skb has been queued to socket prequeue,
> skb_dst(skb)->dev can not anymore point to the device.
> 
> Fortunately in this case the socket pointer is not NULL.
> 
> A similar issue has been fixed in commit 0f85feae6b71 ("tcp: fix
> more NULL deref after prequeue changes"), I should have known better.
> 
> Fixes: 323a53c41292 ("ipv6: tcp: enable flowlabel reflection in some RST packets")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: syzbot <syzkaller@...glegroups.com>

Applied.