netdev - Re: [PATCH v2 bpf-next] selftests/bpf : clean up feature/ when make clean

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0ef29619-baec-64c7-f64a-c7f61e2f8d5b@iogearbox.net>
Date:   Tue, 11 Jun 2019 10:54:32 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Hechao Li <hechaol@...com>, bpf@...r.kernel.org
Cc:     netdev@...r.kernel.org, ast@...nel.org, kernel-team@...com
Subject: Re: [PATCH v2 bpf-next] selftests/bpf : clean up feature/ when make
 clean

On 06/11/2019 02:43 AM, Hechao Li wrote:
> An error "implicit declaration of function 'reallocarray'" can be thrown
> with the following steps:
> 
> $ cd tools/testing/selftests/bpf
> $ make clean && make CC=<Path to GCC 4.8.5>
> $ make clean && make CC=<Path to GCC 7.x>
> 
> The cause is that the feature folder generated by GCC 4.8.5 is not
> removed, leaving feature-reallocarray being 1, which causes reallocarray
> not defined when re-compliing with GCC 7.x. This diff adds feature
> folder to EXTRA_CLEAN to avoid this problem.
> 
> v2: Rephrase the commit message.
> 
> Signed-off-by: Hechao Li <hechaol@...com>
> Acked-by: Andrii Nakryiko <andriin@...com>

Applied, thanks!