netdev - Re: [PATCH net] net: handle 802.1P vlan 0 packets properly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190610.182043.1165253938894520472.davem@davemloft.net>
Date:   Mon, 10 Jun 2019 18:20:43 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     benve@...co.com
Cc:     ssuryaextr@...il.com, gvaradar@...co.com, netdev@...r.kernel.org,
        govind.varadar@...il.com
Subject: Re: [PATCH net] net: handle 802.1P vlan 0 packets properly

From: "Christian Benvenuti (benve)" <benve@...co.com>
Date: Tue, 11 Jun 2019 00:35:59 +0000

>   if we assume that the kernel is supposed to deal properly with .1p tagged frames, regardless
> of what the next header is (802.{1Q,1AD} or something else), I think the case this patch was
> trying to address (that is 1Q+1AD) is not handled properly in the case of priority tagged frames
> when the (1Q) vlan is untagged and therefore 1Q is only used to carry 1p.
>  
>     [1P vid=0][1AD].
> 
> Here is a simplified summary of how the kernel is dealing with priority frames right now, based on
> - what the next protocol is
> and
> - whether a vlan device exists or not for the outer (1Q) header.

Yeah I think I misunderstood the situation.

Please repost the patch.

Thanks.