netdev - Re: [PATCH net-next 4/4] net: dsa: use switchdev handle helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51fe4433-89fc-2090-1a3c-3405ed7a8cc5@gmail.com>
Date:   Tue, 11 Jun 2019 16:10:45 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vivien Didelot <vivien.didelot@...il.com>, netdev@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>, andrew@...n.ch
Subject: Re: [PATCH net-next 4/4] net: dsa: use switchdev handle helpers

On 6/11/19 2:47 PM, Vivien Didelot wrote:
> Get rid of the dsa_slave_switchdev_port_{attr_set,obj}_event functions
> in favor of the switchdev_handle_port_{attr_set,obj_add,obj_del}
> helpers which recurse into the lower devices of the target interface.
> 
> This has the benefit of being aware of the operations made on the
> bridge device itself, where orig_dev is the bridge, and dev is the
> slave. This can be used later to configure bridge-wide attributes on
> the hardware switches.
> 
> Signed-off-by: Vivien Didelot <vivien.didelot@...il.com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>

Nice cleanup, thanks!
-- 
Florian