netdev - Re: [PATCH iproute2] testsuite: don't clobber /tmp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190612085307.35e42bf4@hermes.lan>
Date:   Wed, 12 Jun 2019 08:53:07 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Matteo Croce <mcroce@...hat.com>
Cc:     netdev@...r.kernel.org, David Ahern <dsahern@...nel.org>
Subject: Re: [PATCH iproute2] testsuite: don't clobber /tmp

On Tue, 11 Jun 2019 20:03:26 +0200
Matteo Croce <mcroce@...hat.com> wrote:

> Even if not running the testsuite, every build will leave
> a stale tc_testkenv.* file in the system temp directory.
> Conditionally create the temp file only if we're running the testsuite.
> 
> Signed-off-by: Matteo Croce <mcroce@...hat.com>
> ---
>  testsuite/Makefile | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/testsuite/Makefile b/testsuite/Makefile
> index 7f247bbc..5353244b 100644
> --- a/testsuite/Makefile
> +++ b/testsuite/Makefile
> @@ -14,7 +14,9 @@ TESTS_DIR := $(dir $(TESTS))
>  
>  IPVERS := $(filter-out iproute2/Makefile,$(wildcard iproute2/*))
>  
> -KENVFN := $(shell mktemp /tmp/tc_testkenv.XXXXXX)
> +ifeq ($(MAKECMDGOALS),alltests)
> +	KENVFN := $(shell mktemp /tmp/tc_testkenv.XXXXXX)
> +endif
>  ifneq (,$(wildcard /proc/config.gz))
>  	KCPATH := /proc/config.gz
>  else
> @@ -94,3 +96,4 @@ endif
>  		rm "$$TMP_ERR" "$$TMP_OUT"; \
>  		sudo dmesg > $(RESULTS_DIR)/$@...o.dmesg; \
>  	done
> +	@$(RM) $(KENVFN)

My concern is that there are several targets in this one Makefile.

Why not use -u which gives name but does not create the file?