netdev - Re: [PATCH net-next] net: sched: ingress: set 'unlocked' flag for Qdisc ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190612.092843.1272050301746748492.davem@davemloft.net>
Date:   Wed, 12 Jun 2019 09:28:43 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     vladbu@...lanox.com
Cc:     netdev@...r.kernel.org, jhs@...atatu.com, xiyou.wangcong@...il.com,
        jiri@...nulli.us
Subject: Re: [PATCH net-next] net: sched: ingress: set 'unlocked' flag for
 Qdisc ops

From: Vlad Buslov <vladbu@...lanox.com>
Date: Wed, 12 Jun 2019 10:14:35 +0300

> To remove rtnl lock dependency in tc filter update API when using ingress
> Qdisc, set QDISC_CLASS_OPS_DOIT_UNLOCKED flag in ingress Qdisc_class_ops.
> 
> Ingress Qdisc ops don't require any modifications to be used without rtnl
> lock on tc filter update path. Ingress implementation never changes its
> q->block and only releases it when Qdisc is being destroyed. This means it
> is enough for RTM_{NEWTFILTER|DELTFILTER|GETTFILTER} message handlers to
> hold ingress Qdisc reference while using it without relying on rtnl lock
> protection. Unlocked Qdisc ops support is already implemented in filter
> update path by unlocked cls API patch set.
> 
> Signed-off-by: Vlad Buslov <vladbu@...lanox.com>

Applied.