netdev - Re: [PATCH net-next] net: dsa: mv88e6xxx: lock mutex in port_fdb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190612.105114.943734766905038441.davem@davemloft.net>
Date:   Wed, 12 Jun 2019 10:51:14 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     vivien.didelot@...il.com
Cc:     netdev@...r.kernel.org, andrew@...n.ch, f.fainelli@...il.com
Subject: Re: [PATCH net-next] net: dsa: mv88e6xxx: lock mutex in
 port_fdb_dump

From: Vivien Didelot <vivien.didelot@...il.com>
Date: Wed, 12 Jun 2019 12:42:47 -0400

> During a port FDB dump operation, the mutex protecting the concurrent
> access to the switch registers is currently held by the internal
> mv88e6xxx_port_db_dump and mv88e6xxx_port_db_dump_fid helpers.
> 
> It must be held at the higher level in mv88e6xxx_port_fdb_dump which
> is called directly by DSA through ds->ops->port_fdb_dump. Fix this.
> 
> Signed-off-by: Vivien Didelot <vivien.didelot@...il.com>

Applied.