netdev - Re: [RFC, net-next v0 0/2] Microsemi PHY cable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <027749b1-ed08-f173-ab63-169f5ab5f71d@gmail.com>
Date:   Wed, 12 Jun 2019 12:40:37 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Raju Lakkaraju <Raju.Lakkaraju@...rochip.com>,
        netdev@...r.kernel.org
Cc:     UNGLinuxDriver@...rochip.com, andrew@...n.ch
Subject: Re: [RFC, net-next v0 0/2] Microsemi PHY cable

On 6/12/19 1:57 AM, Raju Lakkaraju wrote:
> This series of patches add the Microsemi PHY cable diagnostics command 
> with PHY Netlink Interface.
> 
> 1. phy_netlink.c and phy_netlink.h files add for PHY diagnostics features
> implementation through PHY Netlink interface.
> 2. phy.c contain the generic functions of "PHY diagnostics". This layer
> independ of the communication layer (i.e. Netlink or IOCTL etc)
> 3. mscc.c contain the 4-pair ethernet PHY driver along with
> PHY diagnostics feature.

Andrew just submitted a similar feature set, except that his changes are
much more comprehensive, and also build on top of ethtool-nl, meaning he
has payed attention to the work that was going on within the netdev
community.

Your submission on the other end appears to be looking for the minimum
amount of code necessary to support the Microsemi PHYs product lines and
does not try very hard to possibly think about an abstraction layer for
other PHYs but Microsemi, that does not really give maintainers
confidence that you have.

Can you review Andrew's patch series and see if you find something
missing for you to plug in support for the Microsemi PHYs?

> ------------
> # nl-app eth0 request
> GroupID = 2
> GroupName = phy_monitor
> 
> Cable Diagnostics Request:
> Operation Status : Success
> Cable Pairs mask : 0xf
> Timeout count    : 84
> Cable diagnostics results:
>     Pair A: Correctly terminated pair, Loop Length: 0 m
>     Pair B: Correctly terminated pair, Loop Length: 0 m
>     Pair C: Correctly terminated pair, Loop Length: 0 m
>     Pair D: Correctly terminated pair, Loop Length: 0 m
>  
> Application git repository path:
> -------------------------------
> https://github.com/lakkarajun/bbb_nl_app
> 
> Raju Lakkaraju (2):
>   net: phy: mscc: Add PHY Netlink Interface along with Cable Diagnostics
>     command
>   net: phy: mscc: Add PHY driver for Cable Diagnostics command
> 
>  drivers/net/phy/Kconfig       |   6 ++
>  drivers/net/phy/Makefile      |   1 +
>  drivers/net/phy/mscc.c        | 128 ++++++++++++++++++++++++
>  drivers/net/phy/phy.c         |  17 ++++
>  drivers/net/phy/phy_netlink.c | 226 ++++++++++++++++++++++++++++++++++++++++++
>  include/linux/phy.h           |  88 ++++++++++++++++
>  include/linux/phy_netlink.h   |  48 +++++++++
>  7 files changed, 514 insertions(+)
>  create mode 100644 drivers/net/phy/phy_netlink.c
>  create mode 100644 include/linux/phy_netlink.h
> 


-- 
Florian