netdev - Re: [PATCH net-next] net: dsa: tag_sja1105: Select CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <005d0239-c0fa-7cd2-aed7-df9c46096b60@infradead.org>
Date:   Tue, 11 Jun 2019 18:56:13 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Vladimir Oltean <olteanv@...il.com>, f.fainelli@...il.com,
        vivien.didelot@...il.com, andrew@...n.ch, sfr@...b.auug.org.au,
        davem@...emloft.net
Cc:     netdev@...r.kernel.org, linux-next@...r.kernel.org
Subject: Re: [PATCH net-next] net: dsa: tag_sja1105: Select CONFIG_PACKING

On 6/11/19 11:47 AM, Vladimir Oltean wrote:
> The packing facility is needed to decode Ethernet meta frames containing
> source port and RX timestamping information.
> 
> The DSA driver selects CONFIG_PACKING, but the tagger did not, and since
> taggers can be now compiled as modules independently from the drivers
> themselves, this is an issue now, as CONFIG_PACKING is disabled by
> default on all architectures.
> 
> Fixes: e53e18a6fe4d ("net: dsa: sja1105: Receive and decode meta frames")
> Signed-off-by: Vladimir Oltean <olteanv@...il.com>
> Reported-by: Randy Dunlap <rdunlap@...radead.org>

Acked-by: Randy Dunlap <rdunlap@...radead.org> # build-tested

Thanks.

> ---
>  net/dsa/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/net/dsa/Kconfig b/net/dsa/Kconfig
> index d449f78c1bd0..6e942dda1bcd 100644
> --- a/net/dsa/Kconfig
> +++ b/net/dsa/Kconfig
> @@ -106,6 +106,7 @@ config NET_DSA_TAG_LAN9303
>  config NET_DSA_TAG_SJA1105
>  	tristate "Tag driver for NXP SJA1105 switches"
>  	select NET_DSA_TAG_8021Q
> +	select PACKING
>  	help
>  	  Say Y or M if you want to enable support for tagging frames with the
>  	  NXP SJA1105 switch family. Both the native tagging protocol (which
> 


-- 
~Randy