netdev - Re: [PATCH net-next] net: axienet: move use of resource after validity check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190612134918.GA18923@lunn.ch>
Date:   Wed, 12 Jun 2019 15:49:18 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Robert Hancock <hancock@...systems.ca>
Cc:     netdev@...r.kernel.org, anirudh@...inx.com, John.Linn@...inx.com
Subject: Re: [PATCH net-next] net: axienet: move use of resource after
 validity check

On Tue, Jun 11, 2019 at 10:56:02AM -0600, Robert Hancock wrote:
> We were accessing the pointer returned from platform_get_resource before
> checking if it was valid, causing an oops if it was not. Move this access
> after the call to devm_ioremap_resource which does the validity check.
> 
> Signed-off-by: Robert Hancock <hancock@...systems.ca>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew