netdev - RE: [PATCH] net: phylink: set the autoneg state in phylink_phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VI1PR0402MB280044028DE01C06D4A1FEECE0EF0@VI1PR0402MB2800.eurprd04.prod.outlook.com>
Date:   Thu, 13 Jun 2019 07:45:59 +0000
From:   Ioana Ciornei <ioana.ciornei@....com>
To:     "linux@...linux.org.uk" <linux@...linux.org.uk>,
        "andrew@...n.ch" <andrew@...n.ch>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>,
        "hkallweit1@...il.com" <hkallweit1@...il.com>,
        "davem@...emloft.net" <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH] net: phylink: set the autoneg state in phylink_phy_change

> Subject: [PATCH] net: phylink: set the autoneg state in phylink_phy_change
> 
> The phy_state field of phylink should carry only valid information especially
> when this can be passed to the .mac_config callback.
> Update the an_enabled field with the autoneg state in the phylink_phy_change
> function.
> 
> Fixes: 9525ae83959b ("phylink: add phylink infrastructure")
> Signed-off-by: Ioana Ciornei <ioana.ciornei@....com>
> ---
>  drivers/net/phy/phylink.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c index
> 5d0af041b8f9..dd1feb7b5472 100644
> --- a/drivers/net/phy/phylink.c
> +++ b/drivers/net/phy/phylink.c
> @@ -688,6 +688,7 @@ static void phylink_phy_change(struct phy_device
> *phydev, bool up,
>  		pl->phy_state.pause |= MLO_PAUSE_ASYM;
>  	pl->phy_state.interface = phydev->interface;
>  	pl->phy_state.link = up;
> +	pl->phy_state.an_enabled = phydev->autoneg;
>  	mutex_unlock(&pl->state_mutex);
> 
>  	phylink_run_resolve(pl);
> --
> 1.9.1

Unfortunately, I am not able to find this patch on any netdev list archive.

One other interesting thing that I noticed is that both netdev and the linux-kernel list received the last message around '12 Jun 2019 21:15'. [1][2]
I am just trying to see if there is a problem on my side or something else.

--
Ioana

[1] https://marc.info/?l=linux-netdev&m=156037411432212&w=2
[2] https://marc.info/?l=linux-kernel&m=156037415432226&w=2