netdev - Re: [PATCH bpf v2 1/2] bpf: simplify definition of BPF_FIB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <74a2e31b-b481-b055-8004-1d3176538510@iogearbox.net>
Date:   Thu, 13 Jun 2019 22:48:41 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Martynas Pumputis <m@...bda.lt>, netdev@...r.kernel.org
Cc:     bpf@...r.kernel.org, ast@...nel.org
Subject: Re: [PATCH bpf v2 1/2] bpf: simplify definition of BPF_FIB_LOOKUP
 related flags

On 06/12/2019 06:05 PM, Martynas Pumputis wrote:
> Previously, the BPF_FIB_LOOKUP_{DIRECT,OUTPUT} flags were defined
> with the help of BIT macro. This had the following issues:
> 
> - In order to user any of the flags, a user was required to depend
>   on <linux/bits.h>.
> - No other flag in bpf.h uses the macro, so it seems that an unwritten
>   convention is to use (1 << (nr)) to define BPF-related flags.
> 
> Signed-off-by: Martynas Pumputis <m@...bda.lt>

Applied, thanks!