netdev - Re: [PATCH net-next 1/3] net/sched: Introduce action ct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7ad9dd803e3d961fef3ceaf77215f27e02b04981.camel@redhat.com>
Date:   Thu, 13 Jun 2019 12:49:15 +0200
From:   Davide Caratti <dcaratti@...hat.com>
To:     Paul Blakey <paulb@...lanox.com>, Jiri Pirko <jiri@...lanox.com>,
        Roi Dayan <roid@...lanox.com>,
        Yossi Kuperman <yossiku@...lanox.com>,
        Oz Shlomo <ozsh@...lanox.com>,
        Marcelo Ricardo Leitner <marcelo.leitner@...il.com>,
        netdev@...r.kernel.org, David Miller <davem@...emloft.net>,
        Aaron Conole <aconole@...hat.com>,
        Zhike Wang <wangzhike@...com>
Cc:     Justin Pettit <jpettit@....org>,
        John Hurley <john.hurley@...ronome.com>,
        Rony Efraim <ronye@...lanox.com>, nst-kernel@...hat.com,
        Simon Horman <simon.horman@...ronome.com>
Subject: Re: [PATCH net-next 1/3] net/sched: Introduce action ct

On Thu, 2019-06-13 at 12:16 +0200, Davide Caratti wrote:
> hello Paul!
> 
> On Tue, 2019-06-11 at 16:28 +0300, Paul Blakey wrote:
> 
> > +#endif /* __NET_TC_CT_H */
> > diff --git a/include/uapi/linux/pkt_cls.h b/include/uapi/linux/pkt_cls.h
> > index a93680f..c5264d7 100644
> > --- a/include/uapi/linux/pkt_cls.h
> > +++ b/include/uapi/linux/pkt_cls.h
> > @@ -83,6 +83,7 @@ enum {
> >  #define TCA_ACT_SIMP 22
> >  #define TCA_ACT_IFE 25
> >  #define TCA_ACT_SAMPLE 26
> > +#define TCA_ACT_CT 27
> 
> ^^  I think you can't use 27 (act_ctinfo forgot to explicitly define it),
> or the uAPI will break. See below:

[...]

Nevermind, I just read the comment above the definition of TCA_ACT_GACT.
> > 
> so, I think you should use 28. And I will send a patch for net-next now
> that adds the missing define for TCA_ID_CTINFO. Ok?

we don't need to patch pkt_cls.h. Just avoid 

#define TCA_ACT_CT 27 

and the assignment in the enum, that should be sufficient.
-- 
davide