netdev - Re: [PATCH] af_key: Fix memory leak in key_notify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 14 Jun 2019 12:17:08 +0200
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Jeremy Sowden <jeremy@...zel.net>
CC:     <herbert@...dor.apana.org.au>, <davem@...emloft.net>,
        <netdev@...r.kernel.org>
Subject: Re: [PATCH] af_key: Fix memory leak in key_notify_policy.

On Fri, Jun 14, 2019 at 11:13:38AM +0100, Jeremy Sowden wrote:
> 
> That reminds me.  Stephen Rothwell reported a problem with the "Fixes:"
> tag:
> 
> On 2019-05-29, at 07:48:12 +1000, Stephen Rothwell wrote:
> > In commit
> >
> >   7c80eb1c7e2b ("af_key: fix leaks in key_pol_get_resp and dump_sp.")
> >
> > Fixes tag
> >
> >   Fixes: 55569ce256ce ("Fix conversion between IPSEC_MODE_xxx and XFRM_MODE_xxx.")
> >
> > has these problem(s):
> >
> >   - Subject does not match target commit subject
> >     Just use
> > 	git log -1 --format='Fixes: %h ("%s")'
> 
> What's the procedure for fixing this sort of thing?  Do you need me to
> do anything?

No, that patch is already commited. We can't change the commit
message anymore. Just keep it in mind for next time.