netdev - Re: [PATCH] l2tp: no need to check return value of debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190614115506.GA28890@linux.home>
Date:   Fri, 14 Jun 2019 13:55:07 +0200
From:   Guillaume Nault <gnault@...hat.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Guillaume Nault <g.nault@...halink.fr>, netdev@...r.kernel.org
Subject: Re: [PATCH] l2tp: no need to check return value of debugfs_create
 functions

On Fri, Jun 14, 2019 at 09:04:38AM +0200, Greg Kroah-Hartman wrote:
> When calling debugfs functions, there is no need to ever check the
> return value.  The function can work or not, but the code logic should
> never do something different based on this.
> 
> Also, there is no need to store the individual debugfs file name, just
> remove the whole directory all at once, saving a local variable.
> 
Acked-by: Guillaume Nault <gnault@...hat.com>