[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190614150827.GA9460@lst.de>
Date: Fri, 14 Jun 2019 17:08:27 +0200
From: 'Christoph Hellwig' <hch@....de>
To: Robin Murphy <robin.murphy@....com>
Cc: 'Christoph Hellwig' <hch@....de>,
David Laight <David.Laight@...LAB.COM>,
Maxime Ripard <maxime.ripard@...tlin.com>,
Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>,
"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
"linux-mm@...ck.org" <linux-mm@...ck.org>,
"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
"linux-s390@...r.kernel.org" <linux-s390@...r.kernel.org>,
"linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
David Airlie <airlied@...ux.ie>,
"linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
Intel Linux Wireless <linuxwifi@...el.com>,
"intel-gfx@...ts.freedesktop.org" <intel-gfx@...ts.freedesktop.org>,
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Jani Nikula <jani.nikula@...ux.intel.com>,
Ian Abbott <abbotti@....co.uk>,
Rodrigo Vivi <rodrigo.vivi@...el.com>,
Sean Paul <sean@...rly.run>,
"moderated list:ARM PORT" <linux-arm-kernel@...ts.infradead.org>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
H Hartley Sweeten <hsweeten@...ionengravers.com>,
"iommu@...ts.linux-foundation.org" <iommu@...ts.linux-foundation.org>,
Daniel Vetter <daniel@...ll.ch>
Subject: Re: [PATCH 16/16] dma-mapping: use exact allocation in
dma_alloc_contiguous
On Fri, Jun 14, 2019 at 04:05:33PM +0100, Robin Murphy wrote:
> That said, I don't believe this particular patch should make any
> appreciable difference - alloc_pages_exact() is still going to give back
> the same base address as the rounded up over-allocation would, and
> PAGE_ALIGN()ing the size passed to get_order() already seemed to be
> pointless.
True, we actually do get the right alignment just about anywhere.
Not 100% sure about the various static pool implementations, but we
can make sure if any didn't we'll do that right thing once those
get consolidated.
Powered by blists - more mailing lists