netdev - Re: [PATCH net-next v3 2/2] hinic: add support for rss parameters with ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 14 Jun 2019 08:49:25 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     mkubecek@...e.cz
Cc:     xuechaojing@...wei.com, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, luoshaokai@...wei.com,
        cloud.wangxiaoyun@...wei.com, chiqijun@...wei.com,
        wulike1@...wei.com
Subject: Re: [PATCH net-next v3 2/2] hinic: add support for rss parameters
 with ethtool

From: Michal Kubecek <mkubecek@...e.cz>
Date: Fri, 14 Jun 2019 09:32:09 +0200

> On Thu, Jun 13, 2019 at 01:58:02AM +0000, Xue Chaojing wrote:
>> This patch adds support rss parameters with ethtool,
>> user can change hash key, hash indirection table, hash
>> function by ethtool -X, and show rss parameters by ethtool -x.
>> 
>> Signed-off-by: Xue Chaojing <xuechaojing@...wei.com>
>> ---
> 
> If you are going to submit a new version, please split the patch into
> one moving the existing ethtool code into a new file and one with the
> new features so that it's clear what is new.
> 
> I'm also not sure if an error lever message in kernel log is an
> appropriate response to user trying to perform an unsupported operation,
> in particular if it can be triggered by a regular user.

I think no log message should be reported.