netdev - Re: [net-next 12/12] i40e: mark expected switch fall-through

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3c447eda-2a7b-3d1f-2e15-f2f2f2fa7db8@cogentembedded.com>
Date:   Fri, 14 Jun 2019 21:24:00 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Jeff Kirsher <jeffrey.t.kirsher@...el.com>, davem@...emloft.net
Cc:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        netdev@...r.kernel.org, nhorman@...hat.com, sassmann@...hat.com,
        Andrew Bowers <andrewx.bowers@...el.com>
Subject: Re: [net-next 12/12] i40e: mark expected switch fall-through

On 06/14/2019 12:36 PM, Sergei Shtylyov wrote:

>> From: "Gustavo A. R. Silva" <gustavo@...eddedor.com>
>>
>> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
>> where we are expecting to fall through.
>>
>> This patch fixes the following warning:
>>
>> drivers/net/ethernet/intel/i40e/i40e_xsk.c: In function ‘i40e_run_xdp_zc’:
>> drivers/net/ethernet/intel/i40e/i40e_xsk.c:217:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
>>     bpf_warn_invalid_xdp_action(act);
>>     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/net/ethernet/intel/i40e/i40e_xsk.c:218:2: note: here
>>    case XDP_ABORTED:
>>    ^~~~
>>
>> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
>> where we are expecting to fall through.
>>
>> This patch fixes the following warning:
> 
>    Gustavo repeats yourself. :-)

   Himself, of course. Sorry, hit <send> too early. :-)

>> Signed-off-by: "Gustavo A. R. Silva" <gustavo@...eddedor.com>
>> Tested-by: Andrew Bowers <andrewx.bowers@...el.com>
>> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> [...]

MBR, Sergei