netdev - Re: Cleanup of -Wunused-const-variable in drivers/net/wireless/ti/wl18xx/main.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <874l4slouz.fsf@codeaurora.org>
Date:   Fri, 14 Jun 2019 08:25:56 +0300
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Nathan Huckleberry <nhuck@...gle.com>
Cc:     eliad@...ery.com, davem@...emloft.net, netdev@...r.kernel.org,
        linux-wireless@...r.kernel.org, clang-built-linux@...glegroups.com
Subject: Re: Cleanup of -Wunused-const-variable in drivers/net/wireless/ti/wl18xx/main.c

Nathan Huckleberry <nhuck@...gle.com> writes:

> I'm looking into cleaning up ignored warnings in the kernel so we can
> remove compiler flags to ignore warnings.
>
> There are two unused variables ('wl18xx_iface_ap_cl_limits' and
> 'wl18xx_iface_ap_go_limits') in drivers/net/wireless/ti/wl18xx/main.c.
> These appear to be limits when using p2p devices, yet they are never
> used.
>
> Wanted to reach out for the best course of action to fix the warning.
>
> https://github.com/ClangBuiltLinux/linux/issues/530

The the variables were added in this commit:

commit 7845af35e0deeb7537de759ebc69d6395d4123bf
Author:     Eliad Peller <eliad@...ery.com>
AuthorDate: Thu Jul 30 22:38:22 2015 +0300
Commit:     Kalle Valo <kvalo@...eaurora.org>
CommitDate: Mon Aug 10 22:16:34 2015 +0300

    wlcore: add p2p device support

And even that commit didn't use them, no idea why. Just send a patch
removing them, if someone needs them later they can be added again.

-- 
Kalle Valo