netdev - Re: [PATCH v2 4/5] x86/bpf: Fix 64-bit JIT frame pointer usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190614231311.gfeb47rpjoholuov@treble>
Date:   Fri, 14 Jun 2019 18:13:11 -0500
From:   Josh Poimboeuf <jpoimboe@...hat.com>
To:     Alexei Starovoitov <alexei.starovoitov@...il.com>
Cc:     X86 ML <x86@...nel.org>, Alexei Starovoitov <ast@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Network Development <netdev@...r.kernel.org>,
        bpf <bpf@...r.kernel.org>, Peter Zijlstra <peterz@...radead.org>,
        Song Liu <songliubraving@...com>,
        Kairui Song <kasong@...hat.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        David Laight <David.Laight@...lab.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Borislav Petkov <bp@...en8.de>, Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH v2 4/5] x86/bpf: Fix 64-bit JIT frame pointer usage

On Fri, Jun 14, 2019 at 02:27:30PM -0700, Alexei Starovoitov wrote:
> On Fri, Jun 14, 2019 at 2:19 PM Josh Poimboeuf <jpoimboe@...hat.com> wrote:
> >
> > On Fri, Jun 14, 2019 at 02:05:56PM -0700, Alexei Starovoitov wrote:
> > > Have you tested it ?
> > > I really doubt, since in my test both CONFIG_UNWINDER_ORC and
> > > CONFIG_UNWINDER_FRAME_POINTER failed to unwind through such odd frame.
> >
> > Hm, are you seeing selftest failures?  They seem to work for me.
> >
> > > Here is much simple patch that I mentioned in the email yesterday,
> > > but you failed to listen instead of focusing on perceived 'code readability'.
> > >
> > > It makes one proper frame and both frame and orc unwinders are happy.
> >
> > I'm on my way out the door and I just skimmed it, but it looks fine.
> >
> > Some of the code and patch description look familiar, please be sure to
> > give me proper credit.
> 
> credit means something positive.

So you only give credit for *good* stolen code.  I must have missed that
section of the kernel patch guidelines.

Ironically you posted this patch right after you accused me of removing
Song's SOB (which I didn't).

> your contribution to bpf jit fix was negative.

You have a delightful personality.

-- 
Josh