netdev - Re: [PATCH bpf-next 8/8] selftests/bpf: switch tests to BTF-defined map definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4BzZ5itJ+toa-3Bm3yNxP=CyvNm=CZ5Dg+=nhU=p4CSu=+g@mail.gmail.com>
Date:   Fri, 14 Jun 2019 16:43:41 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Stanislav Fomichev <sdf@...ichev.me>
Cc:     Andrii Nakryiko <andriin@...com>, bpf <bpf@...r.kernel.org>,
        Networking <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Kernel Team <kernel-team@...com>
Subject: Re: [PATCH bpf-next 8/8] selftests/bpf: switch tests to BTF-defined
 map definitions

On Fri, Jun 14, 2019 at 4:23 PM Stanislav Fomichev <sdf@...ichev.me> wrote:
>
> On 06/10, Andrii Nakryiko wrote:
> > Switch test map definition to new BTF-defined format.
> Reiterating my concerns on non-RFC version:
>
> Pretty please, let's not convert everything at once. Let's start
> with stuff that explicitly depends on BTF (spinlocks?).

How about this approach. I can split last commit into two. One
converting all the stuff that needs BTF (spinlocks, etc). Another part
- everything else. If it's so important for your use case, you'll be
able to just back out my last commit. Or we just don't land last
commit.

>
> One good argument (aside from the one that we'd like to be able to
> run tests internally without BTF for a while): libbpf doesn't
> have any tests as far as I'm aware. If we don't have 'legacy' maps in the
> selftests, libbpf may bit rot.

I left few legacy maps exactly for that reason. See progs/test_btf_*.c.

>
> (Andrii, feel free to ignore, since we've already discussed that)
>
> > Signed-off-by: Andrii Nakryiko <andriin@...com>
> > ---


<snip>