netdev - Re: [PATCH net-next] r8169: let mdio read functions return -ETIMEDOUT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190613.224419.1387298560412603697.davem@davemloft.net>
Date:   Thu, 13 Jun 2019 22:44:19 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     nic_swsd@...ltek.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] r8169: let mdio read functions return
 -ETIMEDOUT

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Tue, 11 Jun 2019 21:04:09 +0200

> In case of a timeout currently ~0 is returned. Callers often just check
> whether a certain bit is set and therefore may behave incorrectly.
> So let's return -ETIMEDOUT in case of a timeout.
> 
> r8168_phy_ocp_read is used in r8168g_mdio_read only, therefore we can
> apply the same change.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Applied.