netdev - Re: [PATCH] net: dsa: rtl8366: Fix up VLAN filtering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190615.134132.2175095878545554970.davem@davemloft.net>
Date:   Sat, 15 Jun 2019 13:41:32 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     linus.walleij@...aro.org
Cc:     andrew@...n.ch, vivien.didelot@...oirfairelinux.com,
        f.fainelli@...il.com, netdev@...r.kernel.org,
        stable@...r.kernel.org
Subject: Re: [PATCH] net: dsa: rtl8366: Fix up VLAN filtering

From: Linus Walleij <linus.walleij@...aro.org>
Date: Fri, 14 Jun 2019 00:25:20 +0200

> We get this regression when using RTL8366RB as part of a bridge
> with OpenWrt:
> 
> WARNING: CPU: 0 PID: 1347 at net/switchdev/switchdev.c:291
> 	 switchdev_port_attr_set_now+0x80/0xa4
> lan0: Commit of attribute (id=7) failed.
> (...)
> realtek-smi switch lan0: failed to initialize vlan filtering on this port
> 
> This is because it is trying to disable VLAN filtering
> on VLAN0, as we have forgot to add 1 to the port number
> to get the right VLAN in rtl8366_vlan_filtering(): when
> we initialize the VLAN we associate VLAN1 with port 0,
> VLAN2 with port 1 etc, so we need to add 1 to the port
> offset.
> 
> Fixes: d8652956cf37 ("net: dsa: realtek-smi: Add Realtek SMI driver")
> Cc: stable@...r.kernel.org
> Signed-off-by: Linus Walleij <linus.walleij@...aro.org>

Applied and queued up for -stable.

Please never CC: stable for networking fixes, I handle the stable submissions
myself as per the networking FAQ.

Thank you.